add keyword timeout to I2C -- only used for bitbangioi #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does busio native I2C do clock stretching automatically or have its own register for timeouts? |
|
I could not find any treatment of clock stretching so I assumed it was handled internally by the hardware. The spec does not call for a timeout. There is no limit. By implementing one in bitbangio we are adding a “feature”. |
|
@deshipu noted this in the I2C spec https://www.nxp.com/docs/en/user-guide/UM10204.pdf SMBus has a time-out feature which resets devices if a communication takes too long.
This explains the minimum clock frequency of 10 kHz to prevent locking up the bus. I 2 C
can be a ‘DC’ bus, meaning that a slave device stretches the master clock when
performing some routine while the master is accessing it. This notifies the master that the
slave is busy but does not want to lose the communication. The slave device will allow
continuation after its task is complete. There is no limit in the I 2 C-bus protocol as to how
long this delay can be, whereas for a SMBus system, it would be limited to 35 ms.
SMBus protocol just assumes that if something takes too long, then it means that there is
a problem on the bus and that all devices must reset in order to clear this mode. Slave
devices are not then allowed to hold the clock LOW too long.Should we change the default timeout to 35ms? - it is now 255 microseconds. |
|
Native ASF I2C has clock stretching that's count based. I'm not sure what the time in practice is. |
tannewt
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the keyword "timeout" for bitbangio I2C clock-stretching ( based on code in extmod/machine_i2c.c) --- also added the keyword to busio to keep the API consistent, but it is ignored for busio.
If a timeout occurs a TimeoutError Exception is thrown.